Open
Conversation
Contributor
Author
|
@jmig a new feature, please help review :) |
Contributor
Author
|
Kindly ping, any feedback? @jmig |
Contributor
There was a problem hiding this comment.
Should we allow customization of this font using UIAppearance? That could be handy.
Contributor
|
@ybbaigo Sorry for the delay, I think it is a great feature to add, thanks for the PR! I added a few comments, and I think it will make the code better. Also while we're at it, would you mind adding some SnapshotTests for your feature? It's fairly easy and will improve the library even more. If you need help regarding this, let me know! |
Contributor
Author
|
Got it, thanks for your feedback, @jmig . Due to some reasons, I can't work on this feature today or tomorrow, and will try to submit the next PR with SnapshotTests later this week, just want to let you know. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.