Default to tintColor for selection#21
Open
mikeabdullah wants to merge 1 commit intojivesoftware:masterfrom
Open
Default to tintColor for selection#21mikeabdullah wants to merge 1 commit intojivesoftware:masterfrom
mikeabdullah wants to merge 1 commit intojivesoftware:masterfrom
Conversation
Contributor
|
tintColor is only available with iOS7. And I need (at least for now) to keep this library iOS6 Compatible. I think we should go even further and rethink how the color are handled /override drawRect for performance reasons. |
Contributor
Author
|
Ah, didn't realise iOS 6 compatibility was still being strived for. I suggest leaving this request be for the time being then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now this doesn't quite work though. I think the problem is
-circleSelectedColorgets called before the receiver has been added to the view hierarchy, so it hasn't picked up the app's preferred tint color. Is the intent of this change something you're interested in though?