Skip to content

Conversation

@MarkCiliaVincenti
Copy link
Contributor

No description provided.

@alex-jitbit
Copy link
Member

Thanks for contributing! Have you run the benchmarks before/after?

@MarkCiliaVincenti
Copy link
Contributor Author

Hi, only on https://github.com/MarkCiliaVincenti/Backport.System.Threading.Lock/tree/master/Backport.System.Threading.Lock.Benchmarks

If you test your current benchmarks you should see no difference, but if you change your target framework to net9 and test both versions you should notice a minor improvement. But it's mostly theoretical since it's on EvictExpired.

@MarkCiliaVincenti
Copy link
Contributor Author

Are you still interested in this PR @alex-jitbit?

@alex-jitbit
Copy link
Member

Sorry, I saw you're adding a backport dependency ref to your own package, needed to check if it's malicious or not

@MarkCiliaVincenti
Copy link
Contributor Author

Sorry, I saw you're adding a backport dependency ref to your own package, needed to check if it's malicious or not

Yes indeed. For your info though it is set as a source generator, so it won't be an actual dependency.

@alex-jitbit alex-jitbit merged commit 863219b into jitbit:main Jan 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants