Use unique heatmap name, and other feature updates#179
Open
ycl6 wants to merge 1 commit intojinworks:mainfrom
Open
Use unique heatmap name, and other feature updates#179ycl6 wants to merge 1 commit intojinworks:mainfrom
ycl6 wants to merge 1 commit intojinworks:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A PR with similar changes has been submitted before to sqjin/CellChat#696 to fix an issue with combining heatmaps that are produced by
netVisual_heatmap.This PR (1) resolve the issue with duplicated
Heatmapobject name when joining 2 or more Heatmap objects created by thenetVisual_heatmapfunction, by create a uniqueht.namename and passed to theHeatmapfunction.When creating a heatmap list in the later version of
ComplexHeatmap, eachHeatmapobject should have a unique name, if not, a warning message such asHeatmap/annotation names are duplicatedis produced (as noted in sqjin/CellChat#170).This PR (2) adds the ability for users to assign legend title to each heatmap using
legend.title. This is useful when creating plots showing heatmap side-by-side to compare number/strength of interactions from multiple datasets, with legend named specifically for each dataset.This PR (3) re-introduce the paramaters for users to change the
widthandheightof the heatmap body.Minor changes are to standardise the font size of the legend title and label from
fontsize = 8to usefont.sizewhich default to8.