Skip to content

Properly parse the JSON additionalArtifactKeys#27

Open
andrewmcgilvray wants to merge 1 commit intojimroth:masterfrom
andrewmcgilvray:additionalArtifactKeys
Open

Properly parse the JSON additionalArtifactKeys#27
andrewmcgilvray wants to merge 1 commit intojimroth:masterfrom
andrewmcgilvray:additionalArtifactKeys

Conversation

@andrewmcgilvray
Copy link

Parsing fails when it is an array of strings.
"additionalArtifactKeys":[{"artifactType":"QuicksightManifest","name":"QuickSight/cost_report_hourly_gzip-20210501-20210601-QuickSightManifest.json"},{"artifactType":"RedshiftCommands","name":"20210501-20210601/20210809T193620Z/cost_report_hourly_gzip-RedshiftCommands.sql"},{"artifactType":"RedshiftManifest","name":"20210501-20210601/20210809T193620Z/cost_report_hourly_gzip-RedshiftManifest.json"}]

Parsing fails when it is an array of strings.
"additionalArtifactKeys":[{"artifactType":"QuicksightManifest","name":"QuickSight/cost_report_hourly_gzip-20210501-20210601-QuickSightManifest.json"},{"artifactType":"RedshiftCommands","name":"20210501-20210601/20210809T193620Z/cost_report_hourly_gzip-RedshiftCommands.sql"},{"artifactType":"RedshiftManifest","name":"20210501-20210601/20210809T193620Z/cost_report_hourly_gzip-RedshiftManifest.json"}]
@andrewmcgilvray
Copy link
Author

This change will definitely help people that have any of these options turned on in their cost and usage reports :
image
Without this change Ice will fail.

@adapasuresh
Copy link

Hi Jimroth,

I did deploy the docker image "" into my AWS EKS cluster with below "ice.properties" and am getting below error.
Can you suggest if am missing anything here. S3 has correct permissions with access_ket and secret_key.

ice.properties

Some configuration need some value passed into them.

Do not remove or comment out configurations that have ','

ice.processor=true
ice.reader=true
ice.work_s3bucketname=plural-ice/detailed-billing-bucket
ice.work_s3bucketregion=ap-south-1
ice.work_s3bucketprefix=work/
ice.numthreads=5
ice.hourlyData=true
ice.tagCoverage=none
ice.highstockUrl=https://code.highcharts.com/stock/4.2.1/highstock.js
ice.companyName=Pinelabs
ice.reader.localDir=/mnt/ice_reader
ice.monthlycachesize=12
ice.notice=
ice.processOnce=false
ice.startMonth=2017-06
ice.processor.localDir=/mnt/ice_processor
ice.reservationCapacityPoller=false
ice.breakoutFamilyReservationUsage=false
ice.writeJsonFiles=
ice.tagCoverage=none
ice.reservationPeriod=oneyear
ice.reservationUtilization=PARTIAL
ice.billing_s3bucketname=plural-ice/work-bucket
ice.billing_s3bucketregion=ap-south-1
ice.billing_s3bucketprefix=,
ice.billing_payerAccountId=,
ice.use_blended=
ice.costAndUsageStartDate=2017-10
ice.costAndUsageNetUnblendedStartDate=2019-01
ice.edpDiscounts=2019-01:5
ice.customTags=.

image

@nfonrose
Copy link

nfonrose commented Aug 16, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants