test(protoresolve): implement missing logic in testResolver helper #645
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the
// TODOinresolver_test.goby implementing the verification logic fortestResolver.Changes:
Implemented
testResolver:FindFileByPathcorrectly returns the expected file (desc_test1.proto).Updated
registry_test.go:TestRegistryandTestFromFilespreviously passed empty registries to the helper.testResolvernow strictly checks fordesc_test1.proto, I updated these tests to register the file before calling the helper, ensuring they pass.Verification:-
make testlocally , all tests passed, including the new logic.make cilocally which failed at theerrcheckstep due to a local toolchain issue (internal error: package ... without types), but the code generation and tests are clean. Relying on GitHub Actions for the final lint check.Verification Screenshot: -
