Skip to content

Conversation

@devurandom
Copy link
Contributor

No description provided.

@hno
Copy link

hno commented Aug 21, 2013

Does not seem to allow authentication with empty username (only password). Line 71 " if self.__url.username is not None: " should check that both username and password is None.

But other than this it looks good to me. And also includes the Basic auth encoding fix in Pull #11.

@devurandom
Copy link
Contributor Author

Does not seem to allow authentication with empty username (only password). Line 71 " if self.__url.username is not None: " should check that both username and password is None.

Is that actually possible/allowed and used anywhere? Authenticating with just a password?

@luke-jr
Copy link
Contributor

luke-jr commented Apr 3, 2015

Yes, I personally have used username-less (just a password) authenticated JSON-RPC.

@reiven
Copy link

reiven commented Apr 8, 2015

@luke-jr looks like you need to fix some conflicts

@luke-jr
Copy link
Contributor

luke-jr commented Apr 8, 2015

This isn't my PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants