This repository was archived by the owner on Feb 15, 2024. It is now read-only.
Update to work with python-bitcoinlib 0.7.0 #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
str4d
commented
Dec 6, 2016
| msg = msg_inv() | ||
| while height <= end_height: | ||
| hash = long(self.chaindb.height[str(height)]) | ||
| hash = self.chaindb.getblockhash(height) |
Author
There was a problem hiding this comment.
I'm unsure what the intended behaviour was here, because previously self.chaindb.height[str(height)] could have returned a list of block hashes. For now, the new method defaults to the first hash.
str4d
force-pushed
the
bitcoinlib-0.7.0
branch
from
63ee310 to
61c9d3d
Compare
str4d
force-pushed
the
bitcoinlib-0.7.0
branch
from
61c9d3d to
494302e
Compare
str4d
force-pushed
the
bitcoinlib-0.7.0
branch
from
494302e to
37f50ac
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes a few bugs.