Reduce warnings noise: skip git info without .git dir and avoid CLI version check #316
+17
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sverdlov93
changed the title
sverdlov93
added
improvement
…stence and set JFROG_CLI_AVOID_NEW_VERSION_WARNING to true
sverdlov93
changed the title
sverdlov93
changed the title
sverdlov93
changed the title
MaorEJFrog
reviewed
Jan 8, 2026
| '*password*;*secret*;*key*;*token*;*auth*;JF_ARTIFACTORY_*;JF_ENV_*;JF_URL;JF_USER;JF_PASSWORD;JF_ACCESS_TOKEN', | ||
| ); | ||
| Utils.exportVariableIfNotSet('JFROG_CLI_OFFER_CONFIG', 'false'); | ||
| Utils.exportVariableIfNotSet('JFROG_CLI_AVOID_NEW_VERSION_WARNING', 'true'); |
Collaborator
There was a problem hiding this comment.
Where do you use this env var?
Contributor
Author
There was a problem hiding this comment.
It is an environment variable that affects JFrog CLI behavior by disabling the new existing version check on each run.
The check is useful for local usage, but in CI it is redundant and can trigger GitHub API rate limits (happened to us)
@MaorEJFrog
MaorEJFrog
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR includes two fixes to reduce noise in GitHub workflow summaries.
Fix 1: Skip git info collection when no .git directory exists
Avoids annoying warnings in GitHub workflow summaries when the action runs outside a git directory.
Problem: The action attempts to collect git information via
build-add-giteven when there's no.gitdirectory present, resulting in unnecessary warning messages.Solution: Added a check for the
.gitdirectory before attempting to collect git information. If no.gitdirectory exists, logs an info message and skips the git collection step.Fix 2: Set JFROG_CLI_AVOID_NEW_VERSION_WARNING environment variable
Avoids constant CLI version checks via the GitHub API which can cause rate limiting.
Problem: JFrog CLI performs version checks against GitHub API, which can trigger rate limits during heavy CI usage.
Solution: Set
JFROG_CLI_AVOID_NEW_VERSION_WARNING=trueto disable the version check warning.