Skip to content

Fix Windows temp file cleanup failures in build-add-dependencies command #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bhanurp merged 1 commit into from
Jan 7, 2026
Merged

Fix Windows temp file cleanup failures in build-add-dependencies command #336

bhanurp merged 1 commit into from
Jan 7, 2026
+3 −1

Conversation

@bhanurp
Copy link
Collaborator

@bhanurp bhanurp commented Jan 5, 2026 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • Appropriate label is added to auto generate release notes.
  • I used gofmt for formatting the code before submitting the pull request.
  • PR description is clear and concise, and it includes the proposed solution/fix.

Description

Added missing defer ioutils.Close(reader, &err) in collectRemoteDependencies()

@bhanurp bhanurp added the bug Something isn't working label Jan 5, 2026
@bhanurp bhanurp marked this pull request as ready for review January 6, 2026 04:03
@bhanurp bhanurp merged commit a9a8a41 into jfrog:main Jan 7, 2026
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@itsmeleela itsmeleela itsmeleela approved these changes

@fluxxBot fluxxBot Awaiting requested review from fluxxBot

@nitinp19 nitinp19 Awaiting requested review from nitinp19

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bhanurp @itsmeleela