Skip to content

Conversation

@eranturgeman
Copy link
Contributor

@eranturgeman eranturgeman commented Dec 29, 2025

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.
  • Update documentation about new features / new supported technologies

This PR simplifies the auditPullRequestSourceCode func.
We remove the case where we enable the target results to be absent, since in the new flow we only performing a diff scan. Therefore:

  1. targetBranchWd cannot be empty unless we had an error in creating its temp dir (in this case the error will be thrown in earlier stage)
  2. ResultsToCompare must inhabit a value since if no error happened in the target branch scan we always add these results (if we had an error- it would have thrown in earlier stage)

If both exists as they should - we always add the targetWd path to the scanResultsToIssuesCollection func

@eranturgeman eranturgeman added safe to test Approve running integration tests on a pull request ignore for release Automatically generated release notes labels Dec 29, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 29, 2025
@eranturgeman eranturgeman requested a review from eyalk007 January 1, 2026 11:48
@eranturgeman eranturgeman changed the title Removing 'source results only' logic from PR scan Removing 'source results only' possibility from PR scan Jan 4, 2026
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Jan 4, 2026
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 4, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2026

👍 Frogbot scanned this pull request and did not find any new security issues.


@eranturgeman eranturgeman merged commit 8544f45 into jfrog:v3_er Jan 4, 2026
18 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ignore for release Automatically generated release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants