-
Notifications
You must be signed in to change notification settings - Fork 88
Add shift left release gate connection for v3 #1010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v3_er
Are you sure you want to change the base?
Conversation
| ./bin/set-bitbucket-home.sh | ||
|
|
||
| # Disable Mesh to avoid sidecar startup issues in containerized environments | ||
| export JVM_SUPPORT_RECOMMENDED_ARGS="-Dmesh.enabled=false ${JVM_SUPPORT_RECOMMENDED_ARGS}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will double check if needed but becasue of various issues with enterprise github i added it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dont forget checking before merging @eyalk007
1d78091 to
1179b15
Compare
| - name: 'Scan Pull Request' | ||
| package: 'scanpullrequest' | ||
| - name: 'Package Handlers' | ||
| package: 'packagehandlers' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change package name to packageupdaters if we decide to indeed change the package name in your maven pr
eranturgeman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great!
Just one thing to ensure - in the test.yml we have today we have Cache steps and FastCI optimization steps in several jobs. did you removed them from here on purpose?
Added the workflow file for frogbot v3 release gate
its a separate workflow and not an extension of tests.yml because the setup is very different and to avoid confusion i made it seperate