feat: add delete button to org card #1492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This pull request adds a delete button to Salesforce org cards when they have connection errors, making it easier for users to remove problematic orgs. The delete button appears alongside the "Reconnect Org" button and includes a confirmation modal for safety.
Key Changes:
- Added delete button to org cards with connection errors
- Implemented confirmation dialog before org removal
- Passed remove handler from parent component to connection refresh component
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
libs/features/org-groups/src/lib/SalesforceOrgCardDraggable.tsx |
Passed the onRemoveOrg handler to the SalesforceOrgCardConnectionRefresh component |
libs/features/org-groups/src/lib/SalesforceOrgCardConnectionRefresh.tsx |
Added delete button UI, confirmation modal logic, and prop interface updates for org removal |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
libs/features/org-groups/src/lib/SalesforceOrgCardConnectionRefresh.tsx
Outdated
Show resolved
Hide resolved
libs/features/org-groups/src/lib/SalesforceOrgCardConnectionRefresh.tsx
Outdated
Show resolved
Hide resolved
If an org has a connection error of any kind a delete button shows up to make deleting easier
paustint
force-pushed
the
feat/remove-org-from-card
branch
from
309b847 to
81e3504
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an org has a connection error of any kind
a delete button shows up to make deleting easier