Skip to content

only initialize ./lib/lambda-service once #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
naorpeled merged 4 commits into from
Feb 4, 2025
Merged

only initialize ./lib/lambda-service once #77

naorpeled merged 4 commits into from
Feb 4, 2025

Conversation

@elundh
Copy link
Contributor

@elundh elundh commented Jan 13, 2025

Only initialize ./lib/lambda-service once. Doing this seemed to bring the runtime down much more consistently to 100ms or less (5ms in my case)

naorpeled
naorpeled approved these changes Jan 25, 2025
View reviewed changes
Copy link
Collaborator

@naorpeled naorpeled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @elundh,
the changes look great to me.

Thanks for this 🙏

Could you please fix the CI errors?
I'll happily merge this afterwards.

@elundh
Copy link
Contributor Author

elundh commented Feb 4, 2025

fixed the lint issues.

@naorpeled naorpeled merged commit 1d70db1 into jeremydaly:master Feb 4, 2025
3 of 4 checks passed
@naorpeled naorpeled linked an issue Feb 4, 2025 that may be closed by this pull request
require('./lib/lambda-service') should not reload module every time #76
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@naorpeled naorpeled naorpeled approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

require('./lib/lambda-service') should not reload module every time

2 participants

@elundh @naorpeled