Skip to content

Conversation

@gounthar
Copy link

Hello testlink developers! 👋

This is an automated pull request created by the Jenkins Plugin Modernizer tool. The tool has applied the following recipes to modernize the plugin:

Upgrade to the latest recommended core version and ensure the BOM matches the core version

io.jenkins.tools.pluginmodernizer.UpgradeToRecommendCoreVersion

Upgrade to the latest recommended core version and ensure the BOM matches the core version.

Why is this important?

Jenkins plugins declare a minimum supported Jenkins version.
The minimum Jenkins version is a useful way for plugin developers to indicate the range of Jenkins versions they are willing to support and test.
See the developer documentation to learn more about the recommended minimum Jenkins version.
The current minimum required Jenkins version is 2.462.3, which is why this pull request has been made.

If the plugin is already using the plugin bill of materials, then the bill of materials also needs to be updated with the matching artifactId for the minimum required Jenkins version.

I can't see any change to the Jenkins version, how come?

This means your plugin POM was already using the 2.462.3 version but still required a few adjustments.

The checks fail, why?

For security reasons, the Jenkins infrastructure does not execute Jenkinsfiles proposed in pull requests.
Instead, it builds the code using the Jenkinsfile from the default branch.

In this case, the existing Jenkinsfile specifies Java 8, not Java 11, which is causing the check to fail.
To resolve this,
a maintainer can replay the failed build
by substituting the current Jenkinsfile content with our proposed changes using the "replay the build"
feature in Jenkins.

Please let us know if you need any assistance with this process.

Thanks for taking the time to review this PR.
🙏

Copy link
Member

@kinow kinow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thanks for the PR. Alas, I think there's something else missing somewhere before this can be merged,

‘[EC2 (aws-us-east-2) - Spot Windows 2019 x86_64 with JDK17 (i-0c96db4753d513259)](https://ci.jenkins.io/computer/EC2%20%28aws%2Dus%2Deast%2D2%29%20%2D%20Spot%20Windows%202019%20x86%5F64%20with%20JDK17%20%28i%2D0c96db4753d513259%29/)’ is offline
14:38:02  ‘EC2 (aws-us-east-2) - Spot Windows 2019 x86_64 with JDK8 (i-01e846cc4eab4f6d5)’ doesn’t have label ‘docker-windows&&spot’
14:38:02  ‘s390x-agent’ doesn’t have label ‘docker-windows&&spot’
14:38:03  [ERROR] [ERROR] Some problems were encountered while processing the POMs:
14:38:03  [ERROR] Unknown packaging: hpi @ line 16, column 13
14:38:03   @ 
14:38:03  [ERROR] The build could not read 1 project -> [Help 1]
14:38:03  org.apache.maven.project.ProjectBuildingException: Some problems were encountered while processing the POMs:
14:38:03  [ERROR] Unknown packaging: hpi @ line 16, column 13

@gounthar
Copy link
Author

Thanks for taking the time to review. 🙏

This issue is primarily due to our continued attempts to compile with JDK8, even though we depend on JDK11. This PR is not intended to compile with JDK8, which is why you're seeing this error.

For security reasons, the Jenkins infrastructure defaults to using the Jenkinsfile from the default branch rather than the one supplied with a PR. To ensure this PR passes the checks, you'll need to replay the build within Jenkins using the "Replay the build" feature and the contents of the PR's Jenkinsfile.

Thanks for your understanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants