Open
Conversation
Refines the config screens to be be in sync with current best practices - remove tr in config screens - remove f:block - apply propery styling for selects Refine the columns - place most tooltips on a span instead of the td to avoid that the tooltip looks misplaced when the column is much wider than the actual content - make links to agents, job or build use the same styling as in core - make the agent allocation a link to the label when it is not a selfLabel - add a tooltip with the agents description for the Last Build Node column some code cleanup in java - use pattern variables - use isEmpty for lists
mawinter69
commented
Jan 29, 2026
| triggers = ((AbstractProject<?, ?>) job).getTriggers(); | ||
| } if (job instanceof ParameterizedJobMixIn.ParameterizedJob) { | ||
| triggers = ((ParameterizedJobMixIn.ParameterizedJob)job).getTriggers(); | ||
| if (job instanceof ParameterizedJobMixIn.ParameterizedJob<?, ?> pj) { |
Author
There was a problem hiding this comment.
An AbstractProject is a ParameterizedJobMixIn.ParameterizedJob so that can be simplified.
Member
|
Thank you for this pull request. As a general observation, splitting it up into several smaller PRs would have made it a bit easier to review. I hate to ask this, but did you use any AI-tooling to generate this PR? 😬 |
Author
|
Might be some copilot auto complete proposals that did fit though many didn't fit. But that's it. No asking copilot, claude or cline to do things (as it can be seen a lot in core lately, where it is sometimes obvious that they don't really understand the generated code). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refines the config screens to be be in sync with current best practices
Refine the columns
some code cleanup in java
Testing done
Interactive testing
Submitter checklist