Open
Conversation
davseby
reviewed
Oct 5, 2025
Comment on lines
+640
to
+648
| // Cost returns the total cost of all items currently stored in the cache. | ||
| // Note: Cost tracking is only active when a maximum cost limit is configured. | ||
| // If no maximum cost is set, this method will always return 0. | ||
| func (c *Cache[K, V]) Cost() uint64 { | ||
| c.items.mu.RLock() | ||
| defer c.items.mu.RUnlock() | ||
|
|
||
| return c.cost | ||
| } |
Contributor
There was a problem hiding this comment.
We should probably write a simple test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue:
currently the cache keeps an internal field named
costttlcache/cache.go
Line 40 in a21f6a6
it might be nice to expose it so we don't need to calculate all cost of a cache through loop through all items