Make sure we have a valid host in norm_netloc(). #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@jehiah, how does this look to you? |
Add support for localhost, mailto, Android app URLs
Previously, if we started with a URL like `http://./`, the code in norm_netloc() would start with a host string of '.', strip the dot, and then run into an IndexError when it attempted to look for IPv6 brackets.
jogo
added a commit
to jogo/urlnorm
that referenced
this pull request
May 23, 2022
Making version information consistent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if we started with a URL like
http://./, the code innorm_netloc() would start with a host string of '.', strip the dot,
and then run into an IndexError when it attempted to look for IPv6
brackets.