Implement hit number flash effect #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: jedduffey <jedduffey@gmail.com>
jduffey
force-pushed
the
cursor/implement-hit-number-flash-effect-f7d4
branch
from
ba2ca54 to
49d7d1a
Compare
- Remove unused previousSet state variable that was causing ESLint warnings - Keep correct flash animation logic for newly hit numbers - Ensure only truly new numbers get flash animation, not previously hit numbers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a flashing orange/yellow animation for newly hit numbers in the Roulette UI to provide a clear visual indication.