Skip to content

Comments

fixes uppercase bug; adds tests#6

Closed
kdmukai wants to merge 293 commits intojdlcdl:devfrom
kdmukai:address_qr_all_caps
Closed

fixes uppercase bug; adds tests#6
kdmukai wants to merge 293 commits intojdlcdl:devfrom
kdmukai:address_qr_all_caps

Conversation

@kdmukai
Copy link

@kdmukai kdmukai commented Jan 20, 2025

Description

fixes SeedSigner#665

  • BUGFIX: parse address QR formats that may be in all caps.
  • Refactor the address QR parsing.
  • Add tests, make existing test more DRY.

This pull request is categorized as a:

  • Bug fix
  • Code refactor

Checklist

  • I’ve run pytest and made sure all unit tests pass before sumbitting the PR

If you modified or added functionality/workflow, did you add new unit tests?

  • Yes

I have tested this PR on the following platforms/os:

kdmukai and others added 25 commits December 30, 2024 15:03
[bugfix] `DecodeQR`: handle Compact SeedQR byte data that can be decoded to `str`
[low priority] [bugfix] Update dev tool for creating test SeedQRs
…ficationSuccess

[Screen Redesign] Light rearrangement of SeedAddressVerificationSuccess
Update README.md to fix version naming for verification steps
[Refactor / bugfix] Simplify `HardwareButtons`
Minor 0.8.5-rc1 fixes, syncing translations and screenshots repos
@kdmukai kdmukai changed the base branch from verify_bw_addy_upper to dev January 20, 2025 18:38
@jdlcdl jdlcdl closed this Jan 21, 2025
FreeOnlineUser pushed a commit to FreeOnlineUser/seedsigner that referenced this pull request Jan 3, 2026
fixes for earthdiver functions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BlueWallet addresses may be bech32 in all uppercase.

7 participants