Removed non-required files from stanfordparser.gemspec which prevented successful building.#1
Open
daryltucker wants to merge 1 commit intojcwilk:masterfrom
Open
Removed non-required files from stanfordparser.gemspec which prevented successful building.#1daryltucker wants to merge 1 commit intojcwilk:masterfrom
daryltucker wants to merge 1 commit intojcwilk:masterfrom
Conversation
…d successful building.
Owner
|
Sorry for the delay, could you explain this a bit? What command were you using to build which was failing? |
Author
|
Sorry for the delay (as well). If I remember correctly, I was issuing gem install stanfordparser or similar. stanfordparser.gemspec lists requirements for files which do not exist within this repository. If you check the diff, you'll see which of these files were missing. Once I removed the non-existent files' reference within stanfordparser.gemsec, compilation was successful. |
Owner
|
Thanks for getting back to me, that sounds totally reasonable. Once I get a free day I'll verify and merge it in, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check diff for details.