Add properties to the csproj that were previously in the nuspec file#16
Open
matt-richardson wants to merge 1 commit intojcoutch:masterfrom
Open
Add properties to the csproj that were previously in the nuspec file#16matt-richardson wants to merge 1 commit intojcoutch:masterfrom
matt-richardson wants to merge 1 commit intojcoutch:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The nuget package that is currently on nuget.org doesn't have the project url, license url and other properties set.
(I found this putting together some stuff to track license dependencies on our code)
I believe this is due to the change in how this has been built - it no longer uses the nuspec file to set these properties. I wasn't 100% sure how it was being built, so I didn't delete the nuspec file.
before:
after:
Side note - the statement in the readme
is no longer accurate. DIdn't want to mix it up with this PR though.