Skip to content

Conversation

@kwccoin
Copy link

@kwccoin kwccoin commented Jul 20, 2020

The bug fix need +1 to fix the error about range of destination and source.

The issue is that some commands also check the source/destination index e.g. 798-813 (my adjusted source). They should be the last as u has no src/dest, w has no src, c may use f etc. Hence a change would avoid valgrind alert use of uninitiated variables. Minor as it does no cause bug as it is alway wrong.

I add some commands
r for refresh as some debugging in valgrind of print out better to have refresh command
q with high score
h for help message (and a hint at least h)

Further action:
Doc

  1. Sample document or readme to figure out c1c3 ... etc.
    Input
  2. May try to avoid c/f by using abcd for f so
  • 12 is c1c2
  • [2-c]12 is 2to12c1c2
  • 1a is c1f1
  • wa is wf1
  • w1 is wc1
  • s, h, r, no change
  1. above but with no return needed
    Source
  2. The source is great as it is one page
  3. But I may try to reorganise it so that it is card/input/ncurses-output to make the source ... not sure
  4. May try to do the Clojure one i.e. try
    a) command mode see 2,
    b) object mode not sure and
    c) function mode passing state
    Mostly c as that is the Real Game I want to try

GUI

  1. python version
  2. iOS version
  3. JS version
  4. Not sure I will do Clojure, but may try Lisp

BTW, never pay solitaire but this one is quit addictive, partially because one page C with a fast text game without using mouse. Great work as said. Hope I am not too annoying.

kwccoin and others added 10 commits July 14, 2020 11:02
I wonder whether 2 better imprvoment
- use asd   fg   hjkl;'
         1234 56 7shcd
- this is keyboard based (ncureses is as well)
- and fixed foundation to spade-heart-clubs-diamond
- I also wornder one add a command call auto for end game i.e. random check any one card and if can move to foundation move it and continues move it until it cannot (i.e. save the end game time)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant