Conversation
There was a problem hiding this comment.
Thanks for submitting this.
I'm hesitant to keep a static list of Ubuntu variants that follow this behavior. Looking at the output of uname -v on 12.04, 14.04 and 16.04, the first fields all seem to match the pattern: #[0-9]+-Ubuntu, so one might think it would be at least somewhat reliable to parse on most if not all Ubuntu variations.
I lean toward first parsing the output of uname -v as a fall back (if dist != 'Ubuntu') before raising the ValueError.
|
I can understand these reservations. |
|
I like the idea of |
When running
apt-selecton KDE neon you get a"Must be an Ubuntu OS"error.KDE neon is based on Ubuntu LTS but there doesn't seem to be a standard way to tell from the CLI.
There is a hint in the kernel version name but I have doubts on how reliable that info is:
Thus I added a check against
'neon'in the code.