fix: allow comments in jbang-catalog.json files#144
Open
wfouche wants to merge 8 commits intojbangdev:mainfrom
Open
fix: allow comments in jbang-catalog.json files#144wfouche wants to merge 8 commits intojbangdev:mainfrom
wfouche wants to merge 8 commits intojbangdev:mainfrom
Conversation
Author
|
@maxandersen , this plugin update is ready for review. I've tested the build locally and it works as intended. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Although IntelliJ has built-in support files with a .jsonc extension, it cannot be configured to associated a specific filename with JSONC because at the configuration level it only support JSON or JSON5. JSON5 is a superset of JSONC.
The best we can do is to associated file type JSON5 with jbang-catalog.json.