fix(deprecation): str_replace(): Passing null to parameter #3 ($subject) #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ytaph#3 ($subject) Remaining self deprecation notices (1) 1x: str_replace(): Passing null to parameter jaytaph#3 ($subject) of type array|string is deprecated 1x in RateLimitAnnotationListenerTest::testDispatchIsCalledIfThePathLimitProcessorReturnsARateLimit from Noxlogic\RateLimitBundle\Tests\EventListener
orlandothoeny
force-pushed
the
fix/str-replace-deprecation
branch
from
c4ece31 to
5578dc5
Compare
…ytaph#3 ($subject) Remaining self deprecation notices (1) 1x: str_replace(): Passing null to parameter jaytaph#3 ($subject) of type array|string is deprecated 1x in RateLimitAnnotationListenerTest::testDispatchIsCalledIfThePathLimitProcessorReturnsARateLimit from Noxlogic\RateLimitBundle\Tests\EventListener
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that PHPUnit reports a call to
str_replace()in a way that is deprecated. It looks to me, that this shouldn't ever happen when the code actually executes. I added type information to tell PHP that thestr_replace()$subjectis nevernull.I have added
cannotBeEmpty()to thepathconfig (https://github.com/orlandothoeny/RateLimitBundle/blob/c4ece31865beec1a59b9464e27f785ed98425737/DependencyInjection/Configuration.php#L118-L118), I'm not 100% sure about that. Since its technically a BC break? But I guess passing an empty value is not supported.Gets rid of the following when running the tests: