Closed
Conversation
Contributor
Author
|
@fromanirh Could you take a look at this please? |
ffromani
reviewed
Dec 10, 2021
Collaborator
ffromani
left a comment
ffromani
left a comment
There was a problem hiding this comment.
The code per se looks fine and it is very much like how I'd solve this bug. I think we should have some (at least one) test to exercise the new code path though, also to prevent future regressions.
Signed-off-by: Tai Groot <tai@taigrr.com>
Signed-off-by: Tai Groot <tai@taigrr.com>
Contributor
Author
|
I am closing this PR since github doesn't let you change the name of the source branch for comparison and I now have multiple PRs. I'll reopen and reference this PR in the new one. |
This was referenced Mar 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a disk has no partitions, common use cases for looping over partitions on the disk array created by Block.New() don't work as expected.
Now, underlying partition functions detect partitionless disks and treat a full-disk filesystem as a partition.
The Partition UUID is set to the empty string (since there isn't one), so this behavior can be detected.
This issue will resolve #256