Skip to content

Conversation

Copy link

Copilot AI commented Jan 4, 2026

  • Investigate workflow failures
  • Fix TypeScript compilation error in headerFilter.ts (const reassignment)
  • Add "Source name:" and "Source:" to upstream header filtering
  • Verify tests pass
  • Reply to user comment
Original prompt

In the header section of the compiled list, there are some issues:
-There is redundant information !
! Title: Basic AdGuard DNS Filter
! Last modified: 2026-01-04T02:57:05.825Z
!
! Compiled by @jk-com/adblock-compiler v2.0.0
!
!
! Source name: Source 1
! Source: https://adguardteam.github.io/AdGuardSDNSFilter/Filters/filter.txt
!
!
! Title: AdGuard DNS filter
! Description: Filter composed of several other filters (AdGuard Base filter, Social media filter, Tracking Protection filter, Mobile ads filter, EasyList, EasyPrivacy, etc) and simplified specifically to be better compatible with DNS-level ad blocking.
! Homepage: https://github.com/AdguardTeam/AdguardSDNSFilter
! License: https://github.com/AdguardTeam/AdguardSDNSFilter/blob/master/LICENSE
! Last modified: 2026-01-04T02:52:12.913Z
!
! Compiled by @adguard/hostlist-compiler v1.0.38
!
!
! Source name: AdGuard Base filter ad servers
! Source: https://adguardteam.github.io/AdguardFilters/BaseFilter/sections/adservers.txt
!
!
! This section contains the list of third-party advertising networks domains.
! Note, that we only put rules that block full domains here and not URL parts (there's general_url.txt for that). Also, it must be domains that are used in a third-party context.
! The rules with hints are at the end of file.
!
! Good: ||doubleclick.net^$third-party
! Bad: /banner.jpg (should be in general_url.txt)
! Bad: ||adssubdomain.legitwebsite.com^ (should be in adservers_firstparty.txt)
!
!

  • No references should be present to the adguard repo, it should be referencing this repo.
  • the jk-com compiler needs to print the proper version number as well. It's printing 2.0.0, but it should be referencing the actual version number posted to JSR
  • Did the old compiler support hashing? There should be some kind of checksum present to validate lists.

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: jaypatrick <1800595+jaypatrick@users.noreply.github.com>
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jan 4, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
adblock-compiler 0fa9f36 Jan 04 2026, 03:40 AM

Copilot AI and others added 3 commits January 4, 2026 03:14
Co-authored-by: jaypatrick <1800595+jaypatrick@users.noreply.github.com>
Co-authored-by: jaypatrick <1800595+jaypatrick@users.noreply.github.com>
Co-authored-by: jaypatrick <1800595+jaypatrick@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix redundant information in compiled list header Fix header metadata: version, package name, checksum, and redundant upstream headers Jan 4, 2026
Copilot AI requested a review from jaypatrick January 4, 2026 03:20
Copy link
Owner

@jaypatrick jaypatrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot all of the workflows are failing now. Please fix them.

Copilot AI and others added 2 commits January 4, 2026 03:28
Co-authored-by: jaypatrick <1800595+jaypatrick@users.noreply.github.com>
Co-authored-by: jaypatrick <1800595+jaypatrick@users.noreply.github.com>
Copy link
Author

Copilot AI commented Jan 4, 2026

@copilot all of the workflows are failing now. Please fix them.

The workflows are showing "action_required" status, which means they're waiting for approval to run. This is a GitHub security feature for workflows triggered by bot accounts on PRs.

You'll need to manually approve the workflow runs in the Actions tab. Once approved, they should run successfully - the type checking already passed in the previous run (commit 0edeed6), and I've fixed the TypeScript compilation error.

If you approve the latest workflow run for commit 0fa9f36, it should pass all checks.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • dl.deno.land
    • Triggering command: /usr/bin/curl curl -s REDACTED (dns block)
  • https://api.github.com/repos/jaypatrick/adblock-compiler/actions/jobs/59388886809/logs
    • Triggering command: /usr/bin/curl curl -s -H Accept: application/vnd.github&#43;json REDACTED (http block)
  • https://api.github.com/repos/jaypatrick/adblock-compiler/actions/jobs/59388886826/logs
    • Triggering command: /usr/bin/curl curl -s -H Accept: application/vnd.github&#43;json REDACTED (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI requested a review from jaypatrick January 4, 2026 03:47
@jaypatrick jaypatrick marked this pull request as ready for review January 4, 2026 03:50
@jaypatrick jaypatrick merged commit 9426327 into master Jan 4, 2026
8 checks passed
@jaypatrick jaypatrick deleted the copilot/fix-redundant-header-info branch January 4, 2026 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants