This repository was archived by the owner on Sep 12, 2024. It is now read-only.
syntax error message improve #547
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
ThakeeNathees
changed the title
ThakeeNathees
force-pushed
the
thakee-syntax-error-message
branch
from
cf72a31 to
c01fcf6
Compare
marsninja
suggested changes
Aug 1, 2024
Contributor
marsninja
left a comment
marsninja
left a comment
There was a problem hiding this comment.
This LGTM save for 1 quick change, since we're now making the repo dependent on pytest lets add it to pyproject.toml dev dependencies.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now the alerts are printed with the visual location indication for the end user to understand cleanly. Here are the screen shots of the implementation and the old one.
Current:
Previous: