On macOS >= 12, don't use vfork(2) #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Addresses #34. |
tov
force-pushed
the
vfork-deprecated
branch
2 times, most recently
from
cfd1373 to
956c91f
Compare
tov
force-pushed
the
master
branch
3 times, most recently
from
8a85852 to
c3be198
Compare
tov
force-pushed
the
vfork-deprecated
branch
3 times, most recently
from
41f2e63 to
6e02a7b
Compare
aalekseyev
approved these changes
Jul 26, 2022
Contributor
aalekseyev
left a comment
aalekseyev
left a comment
There was a problem hiding this comment.
This is sad because fork is slow, but I don't have any better idea.
It's deprecated. Use fork(2) instead. Signed-off-by: Jesse A. Tov <jesse.tov@gmail.com>
vfork(2) is deprecated on macOS 12, so we need to test on both. Signed-off-by: Jesse Tov <jtov@janestreet.com>
Contributor
Author
Maybe #47 is preferable? |
Collaborator
|
On recent versions of Macos, vfork is just aliased to fork. So I would welcome this PR to disable vfork on macos completely |
Because I can't figure out how to run the CI without making a change. Signed-off-by: Jesse A. Tov <jesse.tov@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vfork(2) is deprecated on macOS >= 12, so we need to use fork(2) instead to avoid deprecation warnings. (Should we use posix_spawn(2) where available?)