Fixed Issue #69 #70
Open
Fixed Issue #69 #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…al dependency of python-beautifulsoup4 but it is required by Remarkable to export to HTML
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As stated, fixes issue #69 adding both missing dependency on Arch and graceful handling of exceptions upon exporting to HTML. As a bonus, now exceptions thrown while instantiating
BeautifulSoupdon't create an empty HTML file. Also renamed the variable that holds the HTML file object fromfiletohtml_fileto avoid the accidental replacement of the builtinfilename (old constructor for FILE objects in Python 2).Note: My editor also happens to trim extra white spaces.