Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR enhances the extension's tab management by preserving tab group context when opening new tabs. When a user opens a new tab from within a Chrome tab group, the new tab will automatically be placed in the same group, maintaining organizational context.
Problem
Previously, when opening new tabs from the extension, they would be created without any group association, even if the source tab was part of a tab group. This broke the user's organizational structure and required manual re-grouping of tabs.
Solution
Implemented a flexible tab grouping system that:
Implementation Details
1. Browser Abstraction Layer (
webext.ts)2. Tab Group Strategy (
gopath.ts)Added two grouping strategies:
3. Tab Creation Logic
Cross-browser Compatibility
Testing
To test this change:
Sorry about them being gifs and low res. Github has a 10Mb limit on file uploads
Firefox Test:
Chrome Test: