add jpg to observer #468
add jpg to observer #468
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| { | ||
| public string Params { get; set; } | ||
| public string Warnings { get; set; } | ||
| public string Steps { get; set; } | ||
| public string Sampler { get; set; } | ||
| public string CFGScale { get; set; } | ||
| public string Seed { get; set; } | ||
| public string Size { get; set; } | ||
| public string ClipSkip { get; set; } | ||
| public string DenoisingStrength { get; set; } | ||
| public string BatchSize { get; set; } | ||
| public string BatchPos { get; set; } | ||
| public string FaceRestoration { get; set; } | ||
| public string Eta { get; set; } | ||
| public string FirstPassSize { get; set; } | ||
| public string ENSD { get; set; } | ||
| public string Hypernet { get; set; } | ||
| public string HypernetHash { get; set; } | ||
| public string HypernetStrength { get; set; } | ||
| public string MaskBlur { get; set; } | ||
| public string VariationSeed { get; set; } | ||
| public string VariationSeedStrength { get; set; } | ||
| public string SeedResizeFrom { get; set; } | ||
| public string HiresResize { get; set; } | ||
| public string HiresUpscaler { get; set; } | ||
| public string HiresUpscale { get; set; } | ||
| public string HiresSteps { get; set; } | ||
| public string Warnings { get; set; } | ||
| } |
There was a problem hiding this comment.
Auto1111GenerationParams now exposes only Params and Warnings, removing the previous properties for steps, sampler, CFG scale, seed, hi‑res settings, etc., while Auto1111ParameterDecoder still parses those values (constants at the top of the same file) but no longer surfaces them. Any caller requesting generation parameters from a PNG now receives null for all of those fields, losing metadata that was previously returned and leaving the parsing work unused. This is a regression unrelated to adding .jpg support and will break consumers relying on those properties.
Useful? React with 👍 / 👎.
No description provided.