Prevent thread-local variable leak #185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tagliala
force-pushed
the
bugfix/184-prevent-thread-leak-on-error
branch
from
307baa2 to
124ffdd
Compare
Previously, if the block passed to `with_asset_finder` raised an exception, the thread-local variable `:inline_svg_asset_finder` was not cleared, leading to potential leakage across threads. This change ensures that the variable is always cleared using an `ensure` block, even if an error occurs. Close jamesmartin#184
tagliala
force-pushed
the
bugfix/184-prevent-thread-leak-on-error
branch
from
124ffdd to
1f9b6c8
Compare
Contributor
Author
|
Hi @jamesmartin, I've find this issue in production code when preparing #183 I would merge this before and then go for the other one |
1 task
jamesmartin
approved these changes
Apr 24, 2025
Owner
|
Thanks, @tagliala. ✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if the block passed to
with_asset_finderraised an exception, the thread-local variable:inline_svg_asset_finderwas not cleared, leading to potential leakage across threads.This change ensures that the variable is always cleared using an
ensureblock, even if an error occurs.Close #184