Open
Conversation
wanovak
commented
May 24, 2022
| RUN cd /home/debbit/src && \ | ||
| ln -s /usr/local/bin/geckodriver ./program_files/geckodriver && \ | ||
| ln -s /opt/firefox/firefox /usr/local/bin/firefox && \ | ||
| cp ./debbit.py /opt/firefox/ && \ |
Author
There was a problem hiding this comment.
This shouldn't be necessary. I'm thinking there's something wrong with the python source but did not investigate.
wanovak
commented
May 24, 2022
|
|
||
| WORKDIR /home/debbit/src | ||
|
|
||
| CMD ["python3", "-m", "pipenv", "run", "python3", "./debbit.py"] |
Author
There was a problem hiding this comment.
I would love for someone to tell my why this is wrong. It looks wrong, but I don't know the python ecosystem well enough to say why.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a very bare bones implementation to get this containerized. I don't know python well so if I did something stupid with its tooling, I apologize :-)
Makefileto specify the path of debbitsudo make buildsudo make runPlease feel free to suggest modifications.