Skip to content

Fix AttributeParserExtension tests#1620

Merged
Stanton merged 7 commits intodevelopfrom
codex/adjust-method-implementation-for-consistency
Jun 9, 2025
Merged

Fix AttributeParserExtension tests#1620
Stanton merged 7 commits intodevelopfrom
codex/adjust-method-implementation-for-consistency

Conversation

@Stanton
Copy link
Member

@Stanton Stanton commented Jun 9, 2025

Summary

  • fix unit test method names to reflect returning empty strings instead of false
  • phpunit tests now pass

Testing

  • phpunit -c phpunit.xml.dist

https://chatgpt.com/codex/tasks/task_b_68471869ba34832285a8fa0994978ce2

@Stanton Stanton changed the base branch from main to develop June 9, 2025 18:10
@Stanton Stanton merged commit d364849 into develop Jun 9, 2025
11 checks passed
@Stanton Stanton deleted the codex/adjust-method-implementation-for-consistency branch June 9, 2025 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant