Skip to content

Conversation

@jacoyutorius
Copy link
Owner

ジェネレーターを改修。

  • パスワードに利用するFakerのカテゴリーを増やした
  • 単語の一部の文字を大文字に変換した
  • 数値が末尾だけでなく、ランダムな位置に配置されるようにした

- パスワードに利用するFakerのカテゴリーを増やした
- 単語の一部の文字を大文字に変換した
- 数値が末尾だけでなく、ランダムな位置に配置されるようにした
@jacoyutorius jacoyutorius requested a review from Copilot June 23, 2025 13:34
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the Passfaker generator by expanding word sources, introducing random uppercase transformations, and allowing numbers to appear at arbitrary positions.

  • Added new Faker categories for password components
  • Implemented random_char_upcase to uppercase one character per word
  • Changed number insertion and ordering, and bumped version to 0.2.0

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
spec/passfaker_spec.rb Updated the regex to detect digits anywhere in the password
lib/passfaker/version.rb Bumped VERSION from 0.1.0 to 0.2.0
lib/passfaker/generator.rb Added new Faker categories, removed internal dashes, uppercased a random char, shuffled words & numbers
Comments suppressed due to low confidence (1)

lib/passfaker/generator.rb:32

  • The new random_char_upcase method introduces behavior that isn’t currently exercised by any spec. Consider adding a test to verify that exactly one character is randomly converted to uppercase.
    def self.random_char_upcase(word)

@jacoyutorius jacoyutorius merged commit 3160e59 into main Jun 23, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants