Open
Conversation
vrom911
approved these changes
Oct 2, 2020
vrom911
left a comment
vrom911
left a comment
There was a problem hiding this comment.
Great start of the course 🌟
And well done with the advanced task 👍🏼
src/Chapter1.hs
Outdated
| firstDigit n = error "firstDigit: Not implemented!" | ||
| firstDigit :: Int -> Int | ||
| firstDigit n | ||
| | div n 10 == 0 = n |
There was a problem hiding this comment.
You are almost there! 💪🏼 This is a nice solution, however, it won't work on the negative input.
Owner
Author
There was a problem hiding this comment.
I did putting the abs on, but I feel it can be reduced
|
@jacksjm Nice work on Chapter One! This PR is ready for merge 🏁 |
jacksjm
added
the
hacktoberfest-accepted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solutions for Chapter 1
cc @vrom911 @chshersh