Skip to content

Skip standard_conforming_strings=off on PG19 #2506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jackc merged 1 commit into from
Feb 20, 2026
+19 −0
Merged

Skip standard_conforming_strings=off on PG19 #2506

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions pgxtest/pgxtest.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,3 +171,21 @@ func SkipPostgreSQLVersionLessThan(t testing.TB, conn *pgx.Conn, minVersion int6
t.Skipf("Test requires PostgreSQL v%d+", minVersion)
}
}

func SkipPostgreSQLVersionGreaterThan(t testing.TB, conn *pgx.Conn, maxVersion int64) {
serverVersionStr := conn.PgConn().ParameterStatus("server_version")
serverVersionStr = regexp.MustCompile(`^[0-9]+`).FindString(serverVersionStr)
// if not PostgreSQL do nothing
if serverVersionStr == "" {
return
}

serverVersion, err := strconv.ParseInt(serverVersionStr, 10, 64)
if err != nil {
t.Fatalf("postgres version parsed failed: %s", err)
}

if serverVersion > maxVersion {
t.Skipf("Test requires PostgreSQL v%d or lower", maxVersion)
}
}
1 change: 1 addition & 0 deletions query_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2031,6 +2031,7 @@ func TestConnSimpleProtocolRefusesNonStandardConformingStrings(t *testing.T) {
defer closeConn(t, conn)

pgxtest.SkipCockroachDB(t, conn, "Server does not support standard_conforming_strings = off (https://github.com/cockroachdb/cockroach/issues/36215)")
pgxtest.SkipPostgreSQLVersionGreaterThan(t, conn, 18) // PG19 stopped supporting standard_conforming_strings = off

mustExec(t, conn, "set standard_conforming_strings to off")

Expand Down
Loading