Open
Conversation
jGRUBBS
approved these changes
Mar 19, 2018
|
|
||
| module ClassMethods | ||
|
|
||
| # FIX ME: Are these needed? |
Owner
There was a problem hiding this comment.
does not seem like these are used / needed
| def unique_id(field, block) | ||
| const_set('BLOCK', block) | ||
| const_set('FIELD', field) | ||
| const_set('UNIQUE_IDENTIFIER_FIELD', field) |
Owner
There was a problem hiding this comment.
I like the more explicit constants. Less likely to be overwritten or override other constants.
| def generate_unique_id | ||
| return if self.send(self.class::FIELD) | ||
| klass = self.class | ||
| klass_field = klass.const_get('UNIQUE_IDENTIFIER_FIELD') |
Owner
There was a problem hiding this comment.
const_get is definitely a cleaner approach
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jGRUBBS see what you think of this.