Skip to content

fix: move window when goto another tabpage #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
phanen wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: move window when goto another tabpage #304

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion lua/fidget/notification/window.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -471,7 +471,17 @@ function M.get_window(row, col, anchor, relative, width, height)
height = math.min(height, M.options.max_height)
end

if state.window_id == nil or not vim.api.nvim_win_is_valid(state.window_id) then
local valid = state.window_id and vim.api.nvim_win_is_valid(state.window_id)

-- Window exists but is in a different tabpage; close it so we can recreate it in the correct tabpage.
-- Can avoid closing when https://github.com/neovim/neovim/pull/35816/files merged
if valid and vim.api.nvim_win_get_tabpage(state.window_id) ~= vim.api.nvim_get_current_tabpage() then
vim.api.nvim_win_close(state.window_id, true)
valid = false
state.window_id = nil
end

if not valid then
-- Create window to display notifications buffer, but don't enter (2nd param)
state.window_id = vim.api.nvim_open_win(M.get_buffer(), false, {
relative = relative,
Expand Down