Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
| def test_read_main(): | ||
| response = client.post("/slack", json={"user_instruction": f"{instructions}"}) | ||
| assert response.json()["status"] == "ok" |
There was a problem hiding this comment.
[P1] Guard Slack endpoint test behind env checks
The new integration test posts to the Slack agent and assumes a live OpenRouter/Slack configuration (response.json()["status"] == "ok"). When the SLACK_USER_TOKEN and OPEN_ROUTER_TOKEN secrets are not available—typical for local contributors—the router returns {..., "status": "failed"} and this assertion will fail, making the entire suite unusable. The other Slack tests already skip when tokens are missing; this one should do the same or mock the agent so tests can be run without external credentials.
Useful? React with 👍 / 👎.
1 participant
Our slack agent can now receive a prompt to post message in the specified channel:
config.pyfor models parameters.Should solve #5