feat:Implemented the new control layout with animated mic ripple and …#15
feat:Implemented the new control layout with animated mic ripple and …#15
Conversation
…contextual actions.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
| _waveformTick, | ||
| (_) => _pushWaveformSample(model), | ||
| ); |
There was a problem hiding this comment.
[P1] Waveform continues updating while recording is paused or discarded
The new recording state logic clears waveformData and resets the timer when a session is paused, stopped, or discarded, but _VoiceToTextViewState still schedules _waveformTimer in initState and never cancels or gates it based on recordingState. As a result, _pushWaveformSample keeps publishing random samples even after discardRecording() has emptied the waveform or when the state is paused/stopped, so the UI immediately repopulates with a live waveform and the “clear” action has no visible effect. Consider starting the periodic sampler only while RecordingState.recording or checking the state before pushing samples so the waveform can actually freeze or clear when recording is inactive.
Useful? React with 👍 / 👎.
Description
Mic Button & Animation
Icons.micbutton that launches/stops recording.RecordingState.recording, a 3-layer pulse animation loops viaAnimationControllerto mimic the reference ripple; paused/stopped states halt the animation so the mic stays calm.Contextual Actions
_handleMicTap, pause/resume/discard) and revised theViewModelto manage aRecordingStateenum plusdiscardRecording().State Logic Enhancements
ViewModelnow tracksrecordingState, resets timers on stop/discard, and clears waveform data when discardingfor a clean restart.
Tests & Dependencies