-
Notifications
You must be signed in to change notification settings - Fork 0
Add recording timer UI and tests #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -43,3 +43,6 @@ app.*.map.json | |
| /android/app/debug | ||
| /android/app/profile | ||
| /android/app/release | ||
|
|
||
| # Devtools | ||
| devtools_options.yaml | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| import 'package:flutter/material.dart'; | ||
|
|
||
| class TimerDisplay extends StatelessWidget { | ||
| const TimerDisplay({super.key, required this.duration}); | ||
|
|
||
| final Duration duration; | ||
|
|
||
| @override | ||
| Widget build(BuildContext context) { | ||
| final textTheme = Theme.of(context).textTheme; | ||
| final style = | ||
| textTheme.titleMedium?.copyWith( | ||
| fontSize: 18, | ||
| fontWeight: FontWeight.w500, | ||
| color: Colors.grey.shade600, | ||
| letterSpacing: 1.2, | ||
| fontFeatures: const [FontFeature.tabularFigures()], | ||
| ) ?? | ||
| const TextStyle( | ||
| fontSize: 18, | ||
| fontWeight: FontWeight.w500, | ||
| color: Color(0xFF757575), | ||
| letterSpacing: 1.2, | ||
| fontFeatures: [FontFeature.tabularFigures()], | ||
| ); | ||
|
|
||
| return Padding( | ||
| padding: const EdgeInsets.symmetric(vertical: 16), | ||
| child: Text(_format(duration), style: style), | ||
| ); | ||
| } | ||
|
|
||
| String _format(Duration duration) { | ||
| String twoDigits(int value) => value.toString().padLeft(2, '0'); | ||
| final minutes = twoDigits(duration.inMinutes.remainder(60)); | ||
| final seconds = twoDigits(duration.inSeconds.remainder(60)); | ||
| return '$minutes:$seconds'; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 changes: 18 additions & 0 deletions
18
test/features/voice_to_text/widget/timer_display_test.dart
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| import 'package:flutter/material.dart'; | ||
| import 'package:flutter_test/flutter_test.dart'; | ||
|
|
||
| import 'package:iva_mobile/features/voice_to_text/widget/timer_display.dart'; | ||
|
|
||
| void main() { | ||
| testWidgets('TimerDisplay formats duration as MM:SS', (tester) async { | ||
| await tester.pumpWidget( | ||
| const MaterialApp( | ||
| home: Scaffold( | ||
| body: TimerDisplay(duration: Duration(minutes: 5, seconds: 9)), | ||
| ), | ||
| ), | ||
| ); | ||
|
|
||
| expect(find.text('05:09'), findsOneWidget); | ||
| }); | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[P0] Import FontFeature to compile TimerDisplay
The new
TimerDisplaywidget callsFontFeature.tabularFigures()but the file only importspackage:flutter/material.dart.FontFeaturelives indart:uiand is not re-exported by the Material barrel, so the widget fails to compile withUndefined class 'FontFeature'. Add an explicitdart:uiimport (or prefix the symbol) so the timer can build.Useful? React with 👍 / 👎.