Conversation
additionally, minor nitpicks i noticed so far:
|
awesome! well... I'm not forcing anything. Should this be merged just ping me if something happens.
Sure. This would mean one background worker that's the source of updates for notifications and smartspacer or two workers?
alright, I'm fetching them because it's what the notification code did... In the status I wanted to show the text state that API returns. If I can get it from the db that's fine too.
yea, I'll remake it properly, but for a quick mod it went quite well. |
what I meant is that the notification worker and the UI would call one and the same function which fetches the parcel from the API and updates the record for it in the database. right now, that's implemented separately for the notification worker and the UI: https://github.com/itsvic-dev/parcel/blob/master/app/src/main/java/dev/itsvic/parceltracker/NotificationWorker.kt#L73-L75 |
Hi,
This PR adds support for Smartspacer so that parcels can be displayed in the At a Glance. I've mostly made this for myself, but seeing that it's not that much code, maybe someone else might benefit from it too.
There's more work on my part for this to be ready, but I wanted to ask a couple of questions:
is this something you're interested in?
is there any one place that triggers updates of the db? for now I'm using notification worker (which... is not good), but maybe I've missed something
how's status from the API different from the one stored in DB? (and which one should be preferred?)
Screenshots:
Also thanks for this awesome project! Looking forward to all the future development.