Draft
Conversation
This commit implements an LL(1) lexer and the parser for the JSON specification. Both the lexer and the parser are integrated in the same structure for the sake of simplicity. There is no buffering of tokens. Any token produced by the lexer is immediately consumed by the parser. In fact, the parser triggers the lexer to create a token only when it requires one.
ghost
approved these changes
Jun 24, 2020
ghost
self-requested a review
The destructor recursively traverses the object tree releasing memory accordingly. Since, key-value pairs are stored in a hash map, the key needs to persist longer than the lifetime of a token, which is where we derive the key from. As of now, tokens are not freed. In the future, we need to implement a recyclable token that is destroyed along with the parser. Removed the `TokenChannel` enumeration because the tokens are always generated on the default channel, given we don't generate tokens for whitespace.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following tasks are achived in this pull request: