Skip to content

Fix warnings and stabilize orbit diagnostics #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
krystophny wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix warnings and stabilize orbit diagnostics #299

krystophny wants to merge 2 commits into from

Conversation

@krystophny
Copy link
Member

@krystophny krystophny commented Jan 6, 2026 •
edited by qodo-code-review bot
Loading

User description

Summary

  • clean up warning sites in orbit integration, diagnostics, samplers, and classification
  • fix cut detector stencil initialization ordering to avoid out-of-bounds access
  • adjust boozer converter imports and shift calculation to remove warnings

Testing

  • make test (timed out while running test_netcdf_results) [log: /tmp/simple_make_test_2026-01-06b.log]
  • make test TEST=test_netcdf_results [log: /tmp/simple_test_netcdf_results_2026-01-06.log]
  • make test TEST=test_engineering [log: /tmp/simple_test_engineering_2026-01-06.log]

PR Type

Bug fix, Enhancement

Description

  • Replace local dp kind definitions with intrinsic iso_fortran_env import

  • Fix cut detector stencil initialization to avoid out-of-bounds array access

  • Remove unused variables and clean up compiler warnings across modules

  • Improve code formatting and fix floating-point comparison logic

Diagram Walkthrough

flowchart LR
  A["Local dp definitions"] -->|Replace with| B["iso_fortran_env import"]
  C["Cut detector loop logic"] -->|Refactor into| D["Two-phase initialization"]
  E["Unused variables"] -->|Remove| F["Clean codebase"]
  G["Floating-point comparison"] -->|Fix| H["Proper zero check"]
Loading

File Walkthrough
Relevant files
Cleanup
2 files
simple_diag_orbit.f90
Remove local dp definition and unused variable                     
+1/-5     
diag_orbit.f90
Remove unused ierr_orbit variable declaration                       
+2/-2     
Enhancement
4 files
classification.f90
Add iso_fortran_env import, remove local dp definition     
+2/-4     
orbit_symplectic.f90
Add iso_fortran_env import, remove unused variables           
+10/-12 
samplers.f90
Add iso_fortran_env import, remove local dp definition     
+2/-4     
sub_alpha_lifetime_can.f90
Add iso_fortran_env import, improve subroutine signatures
 +6/-9     
Bug fix
3 files
cut_detector.f90
Fix stencil initialization and refactor loop logic             
+77/-19 
netcdf_results_output.f90
Fix floating-point zero comparison logic                                 
+1/-1     
boozer_converter.F90
Remove unused import and fix shift calculation                     
+3/-3     

@qodo-code-review
Copy link

qodo-code-review bot commented Jan 6, 2026 •
edited
Loading

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢
No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
⚪
🎫 No ticket provided
  • Create ticket/issue
Codebase Duplication Compliance
⚪
Codebase context is not defined

Follow the guide to enable codebase context checks.

Custom Compliance
🟢
Generic: Comprehensive Audit Trails

Objective: To create a detailed and reliable record of critical system actions for security analysis
and compliance.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Meaningful Naming and Self-Documenting Code

Objective: Ensure all identifiers clearly express their purpose and intent, making code
self-documenting

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Robust Error Handling and Edge Case Management

Objective: Ensure comprehensive error handling that provides meaningful context and graceful
degradation

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Secure Error Handling

Objective: To prevent the leakage of sensitive system information through error messages while
providing sufficient detail for internal debugging.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Secure Logging Practices

Objective: To ensure logs are useful for debugging and auditing without exposing sensitive
information like PII, PHI, or cardholder data.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Security-First Input Validation and Data Handling

Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent
vulnerabilities

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

  • Update
Compliance status legend 🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

@qodo-code-review
Copy link

qodo-code-review bot commented Jan 6, 2026 •
edited
Loading

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
Possible issue
Restore missing solver variables

Restore the declaration of pivot and info variables, which were removed in the
PR. These are necessary for the dgesv LAPACK solver call and their absence will
cause a compilation error.

src/orbit_symplectic.f90 [425]

 real(dp) :: fvec(n), fjac(n,n), jinv(n,n)
+integer :: pivot(n), info

[To ensure code accuracy, apply this suggestion manually]

Suggestion importance[1-10]: 9

__

Why: The PR incorrectly removed the pivot and info variable declarations, which are required by the dgesv LAPACK routine, causing a compilation error. This suggestion correctly restores them.

High
Remove dead code from loop

Remove the unreachable cut detection logic from the initialization loop in
advance_to_cut. The condition if(i.gt.nplagr ...) is always false within this
loop, making the code dead.

src/cut_detector.f90 [88-149]

       do i = 1, nplagr
         call tstep(si, f, z, ierr)
         if (ierr.ne.0) exit
 
         self%par_inv = self%par_inv + z(5)**2 ! parallel adiabatic invariant
 
         self%orb_sten(1:5, i) = z
         self%orb_sten(6, i) = self%par_inv
 
         !-------------------------------------------------------------------------
-        ! Tip detection and interpolation
-
+        ! Tip detection
         if(self%alam_prev.lt.0.d0.and.z(5).gt.0.d0) then
           self%itip=0   !<=tip has been passed
         end if
         self%itip=self%itip+1
         self%alam_prev=z(5)
-
-        !<=use only initialized stencil
-        if(i.gt.nplagr .and. self%itip.eq.nplagr/2) then
-          cut_type = 0
-          call plag_coeff(nplagr, nder, 0d0, self%orb_sten(5, self%ipoi), &
-            self%coef)
-          var_cut = matmul(self%orb_sten(:, self%ipoi), self%coef(0,:))
-          var_cut(2) = modulo(var_cut(2), twopi)
-          var_cut(3) = modulo(var_cut(3), twopi)
-          self%par_inv = self%par_inv - var_cut(6)
-          return
-        end if
-
-        ! End tip detection and interpolation
+        ! End tip detection
 
         !-------------------------------------------------------------------------
-        ! Periodic boundary footprint detection and interpolation
-
+        ! Periodic boundary footprint detection
         if(z(3).gt.dble(self%kper+1)*self%fper) then
           self%iper=0   !<=periodic boundary has been passed
           phiper=dble(self%kper+1)*self%fper
           self%kper=self%kper+1
         elseif(z(3).lt.dble(self%kper)*self%fper) then
           self%iper=0   !<=periodic boundary has been passed
           phiper=dble(self%kper)*self%fper
           self%kper=self%kper-1
         endif
         self%iper=self%iper+1
-
-        !<=use only initialized stencil
-        if(i.gt.nplagr .and. self%iper.eq.nplagr/2) then
-          cut_type = 1
-          !<=stencil around periodic boundary is complete, interpolate
-          call plag_coeff(nplagr, nder, 0d0, self%orb_sten(3, self%ipoi) - &
-            phiper, self%coef)
-          var_cut = matmul(self%orb_sten(:, self%ipoi), self%coef(0,:))
-          var_cut(2) = modulo(var_cut(2), twopi)
-          var_cut(3) = modulo(var_cut(3), twopi)
-          return
-        end if
-
-        ! End periodic boundary footprint detection and interpolation
+        ! End periodic boundary footprint detection
         !-------------------------------------------------------------------------
 
-  end do
+      end do
  • Apply / Chat
Suggestion importance[1-10]: 7

__

Why: The suggestion correctly identifies dead code within the first do loop, where the condition i.gt.nplagr can never be met, making the enclosed logic unreachable.

Medium
General
Use tolerance for zero check

Replace the direct comparison of floating-point values with zero with a check
against a small tolerance (e.g., 1.0e-12_dp) for robustness.

src/netcdf_results_output.f90 [321]

-zend_is_zero = all(abs(zend(1:3, i)) <= 0.0_dp)
+zend_is_zero = all(abs(zend(1:3, i)) <= 1.0e-12_dp)
  • Apply / Chat
Suggestion importance[1-10]: 5

__

Why: The suggestion correctly points out that comparing floating-point numbers directly to zero is fragile and recommends using a small tolerance, which is a standard best practice.

Low
  • Update

@qodo-code-review
Copy link

qodo-code-review bot commented Jan 6, 2026

CI Feedback 🧐

A test triggered by this PR failed. Here is an AI-generated analysis of the failure:

Action: Build and Test

Failed stage: Run Fast Tests (Fortran only) [❌]

Failed test name: test_chartmap_ncsx_map2disc_wall_offset

Failure summary:

The action failed during the CTest phase because 1 out of 47 tests failed:
-
test_chartmap_ncsx_map2disc_wall_offset (shown as test #4) failed with an assertion/tolerance check:

chartmap wall deviates from buffered VMEC boundary: max_to_buffer=6.801169e-03 m (tol
1.000000e-03) at phi=0.253866
This caused ctest to return a non-zero exit status (Errors while
running CTest), which then made the make test-fast target fail (Makefile:47: test-fast), and the
GitHub Action step exited with code 2 (Process completed with exit code 2).

Relevant error logs: 
1:  Runner name: 'debian'
2:  Runner group name: 'default'
...

25:  ssh-user: git
26:  persist-credentials: true
27:  clean: true
28:  sparse-checkout-cone-mode: true
29:  fetch-tags: false
30:  show-progress: true
31:  lfs: false
32:  submodules: false
33:  set-safe-directory: true
34:  env:
35:  LIBNEO_BRANCH: feature/fpm-bind
36:  ##[endgroup]
37:  Syncing repository: itpplasma/SIMPLE
38:  ##[group]Getting Git version info
39:  Working directory is '/home/github-runner/actions-runner/_work/SIMPLE/SIMPLE'
40:  Unexpected error attempting to determine if executable file exists '/home/ert/.npm-global/bin/git': Error: EACCES: permission denied, stat '/home/ert/.npm-global/bin/git'
41:  Unexpected error attempting to determine if executable file exists '/home/ert/code/.venv/bin/git': Error: EACCES: permission denied, stat '/home/ert/code/.venv/bin/git'
42:  Unexpected error attempting to determine if executable file exists '/home/ert/code/scripts/git': Error: EACCES: permission denied, stat '/home/ert/code/scripts/git'
43:  [command]/usr/bin/git version
...

433:  [78/957] Building Fortran preprocessed _deps/fortplot-build/CMakeFiles/fortplot.dir/src/fortplot_colors.f90-pp.f90
434:  [79/957] Building Fortran preprocessed _deps/fortplot-build/CMakeFiles/fortplot.dir/src/fortplot_constants.f90-pp.f90
435:  [80/957] Building Fortran preprocessed _deps/fortplot-build/CMakeFiles/fortplot.dir/src/fortplot_context.f90-pp.f90
436:  [81/957] Building Fortran preprocessed _deps/fortplot-build/CMakeFiles/fortplot.dir/src/fortplot_ci_performance_monitor.f90-pp.f90
437:  [82/957] Building Fortran preprocessed _deps/fortplot-build/CMakeFiles/fortplot.dir/src/fortplot_contour_algorithms.f90-pp.f90
438:  [83/957] Building Fortran preprocessed _deps/fortplot-build/CMakeFiles/fortplot.dir/src/fortplot_doc_constants.f90-pp.f90
439:  [84/957] Building Fortran preprocessed _deps/fortplot-build/CMakeFiles/fortplot.dir/src/fortplot_doc_examples.f90-pp.f90
440:  [85/957] Building Fortran preprocessed _deps/fortplot-build/CMakeFiles/fortplot.dir/src/fortplot_colormap.f90-pp.f90
441:  [86/957] Building Fortran preprocessed _deps/fortplot-build/CMakeFiles/fortplot.dir/src/fortplot_contour_regions.f90-pp.f90
442:  [87/957] Building Fortran preprocessed _deps/fortplot-build/CMakeFiles/fortplot.dir/src/fortplot_doc_files.f90-pp.f90
443:  [88/957] Building Fortran preprocessed _deps/fortplot-build/CMakeFiles/fortplot.dir/src/fortplot_doc_processor.f90-pp.f90
444:  [89/957] Building Fortran preprocessed _deps/fortplot-build/CMakeFiles/fortplot.dir/src/fortplot_doc_media.f90-pp.f90
445:  [90/957] Building Fortran preprocessed _deps/fortplot-build/CMakeFiles/fortplot.dir/src/fortplot_doc_text.f90-pp.f90
446:  [91/957] Building Fortran preprocessed _deps/fortplot-build/CMakeFiles/fortplot.dir/src/fortplot_coordinate_validation.f90-pp.f90
447:  [92/957] Building Fortran preprocessed _deps/fortplot-build/CMakeFiles/fortplot.dir/src/fortplot_doc_paths.f90-pp.f90
448:  [93/957] Building Fortran preprocessed _deps/fortplot-build/CMakeFiles/fortplot.dir/src/fortplot_errors.f90-pp.f90
449:  [94/957] Building Fortran preprocessed _deps/fortplot-build/CMakeFiles/fortplot.dir/src/fortplot_doc_output.f90-pp.f90
...

596:  [241/957] Building Fortran object _deps/libneo-build/CMakeFiles/neo.dir/src/libneo_kinds.f90.o
597:  [242/957] Building Fortran object _deps/libneo-build/CMakeFiles/neo.dir/src/coordinates/libneo_coordinate_conventions.f90.o
598:  [243/957] Building Fortran object _deps/libneo-build/CMakeFiles/neo.dir/src/canonical_coordinates_mod.f90.o
599:  [244/957] Building Fortran preprocessed src/CMakeFiles/simple.dir/diag/diag_albert.f90-pp.f90
600:  [245/957] Building Fortran object _deps/libneo-build/src/contrib/CMakeFiles/CONTRIB.dir/minpack_interfaces.f90.o
601:  [246/957] Building Fortran object _deps/fortplot-build/CMakeFiles/fortplot.dir/src/fortplot_doc_constants.f90.o
602:  [247/957] Building Fortran object _deps/fortplot-build/CMakeFiles/fortplot.dir/src/fortplot_animation_constants.f90.o
603:  [248/957] Building Fortran object _deps/fortplot-build/CMakeFiles/fortplot.dir/src/fortplot_constants.f90.o
604:  [249/957] Building Fortran object _deps/libneo-build/CMakeFiles/neo.dir/src/coordinates/cylindrical_cartesian.f90.o
605:  [250/957] Building C object _deps/libneo-build/CMakeFiles/neo.dir/src/local_rusage.c.o
606:  [251/957] Building Fortran object _deps/libneo-build/CMakeFiles/neo.dir/src/math_constants.f90.o
607:  [252/957] Building Fortran object _deps/libneo-build/CMakeFiles/neo.dir/src/binsrc.f90.o
608:  [253/957] Building Fortran object _deps/libneo-build/CMakeFiles/neo.dir/src/coordinates/libneo_coordinates_base.f90.o
609:  [254/957] Building Fortran object _deps/fortplot-build/CMakeFiles/fortplot.dir/src/fortplot_contour_algorithms.f90.o
610:  [255/957] Building Fortran object _deps/libneo-build/CMakeFiles/neo.dir/src/rusage_type.f90.o
611:  [256/957] Building Fortran object _deps/fortplot-build/CMakeFiles/fortplot.dir/src/fortplot_errors.f90.o
612:  [257/957] Building Fortran object _deps/fortplot-build/CMakeFiles/fortplot.dir/src/fortplot_bmp.f90.o
...

772:  16 |     subroutine text(x, y, text_content, coord_type, font_size, rotation, alignment, has_bbox, ha)
773:  |                        1
774:  Warning: Unused dummy argument ‘y’ at (1) [-Wunused-dummy-argument]
775:  [288/957] Building Fortran object _deps/fortplot-build/CMakeFiles/fortplot.dir/src/fortplot_system_secure.f90.o
776:  [289/957] Building Fortran object _deps/fortplot-build/CMakeFiles/fortplot.dir/src/fortplot_utils_sort.f90.o
777:  [290/957] Building Fortran object _deps/fortplot-build/CMakeFiles/fortplot.dir/src/fortplot_doc_source.f90.o
778:  [291/957] Building Fortran object _deps/libneo-build/src/field/CMakeFiles/neo_field.dir/biotsavart_field.f90.o
779:  [292/957] Building Fortran object _deps/fortplot-build/CMakeFiles/fortplot.dir/src/fortplot_testing.f90.o
780:  [293/957] Building Fortran object _deps/fortplot-build/CMakeFiles/fortplot.dir/src/fortplot_streamline_placement.f90.o
781:  [294/957] Building Fortran object _deps/fortplot-build/CMakeFiles/fortplot.dir/src/fortplot_streamline_integrator.f90.o
782:  /home/github-runner/actions-runner/_work/SIMPLE/SIMPLE/build/_deps/fortplot-src/src/fortplot_streamline_integrator.f90:80:29:
783:  80 |         real(wp) :: tolerance, h_new
784:  |                             1
785:  Warning: Unused variable ‘tolerance’ declared at (1) [-Wunused-variable]
786:  /home/github-runner/actions-runner/_work/SIMPLE/SIMPLE/build/_deps/fortplot-src/src/fortplot_streamline_integrator.f90:77:37:
787:  77 |         real(wp) :: x, y, t, h, x_new, y_new, error_est
788:  |                                     1
789:  Warning: Unused variable ‘x_new’ declared at (1) [-Wunused-variable]
790:  /home/github-runner/actions-runner/_work/SIMPLE/SIMPLE/build/_deps/fortplot-src/src/fortplot_streamline_integrator.f90:77:44:
791:  77 |         real(wp) :: x, y, t, h, x_new, y_new, error_est
792:  |                                            1
...

1041:  [370/957] Building Fortran preprocessed _deps/libneo-build/src/efit_to_boozer/CMakeFiles/efit_to_boozer.dir/spline_and_interpolate_magdata.f90-pp.f90
1042:  [371/957] Generating Fortran dyndep file _deps/libneo-build/CMakeFiles/vmec_to_chartmap.x.dir/Fortran.dd
1043:  [372/957] Building Fortran preprocessed _deps/libneo-build/src/efit_to_boozer/CMakeFiles/efit_to_boozer.dir/rhs.f90-pp.f90
1044:  [373/957] Building Fortran object src/CMakeFiles/simple.dir/timing.f90.o
1045:  [374/957] Building Fortran object src/CMakeFiles/simple.dir/field/field_can_test.f90.o
1046:  [375/957] Building Fortran preprocessed _deps/libneo-build/src/species/CMakeFiles/species.dir/species.f90-pp.f90
1047:  [376/957] Building Fortran object _deps/libneo-build/src/magfie/CMakeFiles/magfie.dir/amn_mod.f90.o
1048:  [377/957] Building Fortran object _deps/libneo-build/src/magfie/CMakeFiles/magfie.dir/bdivfree_mod.f90.o
1049:  [378/957] Building Fortran object _deps/libneo-build/src/magfie/CMakeFiles/magfie.dir/theta_rz_mod.f90.o
1050:  [379/957] Building Fortran object _deps/libneo-build/src/magfie/CMakeFiles/magfie.dir/extract_fluxcoord_mod.f90.o
1051:  [380/957] Building Fortran object _deps/libneo-build/src/magfie/CMakeFiles/magfie.dir/inthecore_mod.f90.o
1052:  [381/957] Building Fortran object _deps/libneo-build/src/magfie/CMakeFiles/magfie.dir/period_mod.f90.o
1053:  [382/957] Building Fortran object src/CMakeFiles/simple.dir/collis_alphas.f90.o
1054:  [383/957] Building Fortran object _deps/fortplot-build/CMakeFiles/fortplot.dir/src/fortplot_streamplot_matplotlib.f90.o
1055:  /home/github-runner/actions-runner/_work/SIMPLE/SIMPLE/build/_deps/fortplot-src/src/fortplot_streamplot_matplotlib.f90:257:16:
1056:  257 |             if (error == 0.0_wp) then
1057:  |                1
...

2286:  /home/github-runner/actions-runner/_work/SIMPLE/SIMPLE/build/_deps/fortplot-src/src/fortplot_matplotlib_io.f90:126:36:
2287:  126 |     subroutine savefig(filename, dpi, transparent, bbox_inches)
2288:  |                                    1
2289:  Warning: Unused dummy argument ‘dpi’ at (1) [-Wunused-dummy-argument]
2290:  /home/github-runner/actions-runner/_work/SIMPLE/SIMPLE/build/_deps/fortplot-src/src/fortplot_matplotlib_io.f90:126:49:
2291:  126 |     subroutine savefig(filename, dpi, transparent, bbox_inches)
2292:  |                                                 1
2293:  Warning: Unused dummy argument ‘transparent’ at (1) [-Wunused-dummy-argument]
2294:  [673/957] Building Fortran object _deps/fortplot-build/CMakeFiles/fortplot.dir/src/fortplot_animation_pipeline.f90.o
2295:  [674/957] Building Fortran object _deps/fortplot-build/CMakeFiles/fortplot.dir/src/fortplot_matplotlib_plotting.f90.o
2296:  /home/github-runner/actions-runner/_work/SIMPLE/SIMPLE/build/_deps/fortplot-src/src/fortplot_matplotlib_plotting.f90:333:59:
2297:  333 |     subroutine add_3d_plot(x, y, z, label, linestyle, color, linewidth, marker, markersize)
2298:  |                                                           1
2299:  Warning: Unused dummy argument ‘color’ at (1) [-Wunused-dummy-argument]
2300:  /home/github-runner/actions-runner/_work/SIMPLE/SIMPLE/build/_deps/fortplot-src/src/fortplot_matplotlib_plotting.f90:259:91:
2301:  259 |     subroutine add_errorbar(x, y, xerr, yerr, fmt, label, capsize, linestyle, marker, color)
2302:  |                                                                                           1
...

2358:  |                    1
2359:  Warning: Unused variable ‘i’ declared at (1) [-Wunused-variable]
2360:  /home/github-runner/actions-runner/_work/SIMPLE/SIMPLE/build/_deps/fortplot-src/src/fortplot_matplotlib_plotting.f90:54:57:
2361:  54 |     subroutine bar(x, height, width, bottom, label, color, edgecolor, align)
2362:  |                                                         1
2363:  Warning: Unused dummy argument ‘color’ at (1) [-Wunused-dummy-argument]
2364:  /home/github-runner/actions-runner/_work/SIMPLE/SIMPLE/build/_deps/fortplot-src/src/fortplot_matplotlib_plotting.f90:54:68:
2365:  54 |     subroutine bar(x, height, width, bottom, label, color, edgecolor, align)
2366:  |                                                                    1
2367:  Warning: Unused dummy argument ‘edgecolor’ at (1) [-Wunused-dummy-argument]
2368:  /home/github-runner/actions-runner/_work/SIMPLE/SIMPLE/build/_deps/fortplot-src/src/fortplot_matplotlib_plotting.f90:65:20:
2369:  65 |         integer :: i
2370:  |                    1
2371:  Warning: Unused variable ‘i’ declared at (1) [-Wunused-variable]
2372:  /home/github-runner/actions-runner/_work/SIMPLE/SIMPLE/build/_deps/fortplot-src/src/fortplot_matplotlib_plotting.f90:41:61:
2373:  41 |     subroutine errorbar(x, y, xerr, yerr, fmt, label, capsize, linestyle, marker, color)
2374:  |                                                             1
2375:  Warning: Unused dummy argument ‘capsize’ at (1) [-Wunused-dummy-argument]
2376:  /home/github-runner/actions-runner/_work/SIMPLE/SIMPLE/build/_deps/fortplot-src/src/fortplot_matplotlib_plotting.f90:41:87:
2377:  41 |     subroutine errorbar(x, y, xerr, yerr, fmt, label, capsize, linestyle, marker, color)
2378:  |                                                                                       1
2379:  Warning: Unused dummy argument ‘color’ at (1) [-Wunused-dummy-argument]
2380:  /home/github-runner/actions-runner/_work/SIMPLE/SIMPLE/build/_deps/fortplot-src/src/fortplot_matplotlib_plotting.f90:41:45:
2381:  41 |     subroutine errorbar(x, y, xerr, yerr, fmt, label, capsize, linestyle, marker, color)
2382:  |                                             1
2383:  Warning: Unused dummy argument ‘fmt’ at (1) [-Wunused-dummy-argument]
2384:  /home/github-runner/actions-runner/_work/SIMPLE/SIMPLE/build/_deps/fortplot-src/src/fortplot_matplotlib_plotting.f90:41:80:
2385:  41 |     subroutine errorbar(x, y, xerr, yerr, fmt, label, capsize, linestyle, marker, color)
2386:  |                                                                                1
2387:  Warning: Unused dummy argument ‘marker’ at (1) [-Wunused-dummy-argument]
2388:  /home/github-runner/actions-runner/_work/SIMPLE/SIMPLE/build/_deps/fortplot-src/src/fortplot_matplotlib_plotting.f90:41:34:
2389:  41 |     subroutine errorbar(x, y, xerr, yerr, fmt, label, capsize, linestyle, marker, color)
2390:  |                                  1
2391:  Warning: Unused dummy argument ‘xerr’ at (1) [-Wunused-dummy-argument]
2392:  /home/github-runner/actions-runner/_work/SIMPLE/SIMPLE/build/_deps/fortplot-src/src/fortplot_matplotlib_plotting.f90:41:40:
2393:  41 |     subroutine errorbar(x, y, xerr, yerr, fmt, label, capsize, linestyle, marker, color)
2394:  |                                        1
...

2769:  Constructing wrapper function "f2py_vmec_wrappers.vmec_field_wrapper"...
2770:  a_theta,a_phi,da_theta_ds,da_phi_ds,aiota,sqg,alam,dl_ds,dl_dt,dl_dp,bctrvr_vartheta,bctrvr_varphi,bcovar_s,bcovar_vartheta,bcovar_varphi = vmec_field_wrapper(s,theta,varphi)
2771:  Constructing wrapper function "f2py_vmec_wrappers.vmec_field_cylindrical_wrapper"...
2772:  br,bphi,bz,bmag = vmec_field_cylindrical_wrapper(s,theta,varphi)
2773:  Wrote C/API module "_magfie" to file "./_magfiemodule.c"
2774:  Fortran 90 wrappers are saved to "./_magfie-f2pywrappers2.f90"
2775:  [729/957] Building Fortran preprocessed _deps/libneo-build/CMakeFiles/_magfie.dir/src/f2py_interfaces/f2py_vmec_support.f90-pp.f90
2776:  [730/957] Building Fortran preprocessed _deps/libneo-build/CMakeFiles/_magfie.dir/_magfie-f2pywrappers2.f90-pp.f90
2777:  [731/957] Building Fortran preprocessed _deps/libneo-build/CMakeFiles/_magfie.dir/src/magfie/magfie_vmec.f90-pp.f90
2778:  [732/957] Building Fortran preprocessed _deps/libneo-build/CMakeFiles/_magfie.dir/_magfie-f2pywrappers.f-pp.f
2779:  [733/957] Building Fortran preprocessed _deps/libneo-build/CMakeFiles/_magfie.dir/src/f2py_interfaces/f2py_vmec_wrappers.f90-pp.f90
2780:  [734/957] Building Fortran preprocessed _deps/libneo-build/CMakeFiles/_magfie.dir/src/f2py_interfaces/f2py_magfie.f90-pp.f90
2781:  [735/957] Generating Fortran dyndep file _deps/libneo-build/CMakeFiles/_magfie.dir/Fortran.dd
2782:  [736/957] Building Fortran object _deps/libneo-build/CMakeFiles/_magfie.dir/_magfie-f2pywrappers.f.o
2783:  [737/957] Generating _efit_to_boozermodule.c, _efit_to_boozer-f2pywrappers.f, _efit_to_boozer-f2pywrappers2.f90
2784:  OSError: [Errno 2] No such file or directory: '/home/github-runner/actions-runner/_work/SIMPLE/SIMPLE/src/magfie/field_divB0.f90'. Skipping file "/home/github-runner/actions-runner/_work/SIMPLE/SIMPLE/src/magfie/field_divB0.f90".
2785:  OSError: [Errno 2] No such file or directory: '/home/github-runner/actions-runner/_work/SIMPLE/SIMPLE/src/magfie/field_eq_mod.f90'. Skipping file "/home/github-runner/actions-runner/_work/SIMPLE/SIMPLE/src/magfie/field_eq_mod.f90".
2786:  OSError: [Errno 2] No such file or directory: '/home/github-runner/actions-runner/_work/SIMPLE/SIMPLE/src/spl_three_to_five.f90'. Skipping file "/home/github-runner/actions-runner/_work/SIMPLE/SIMPLE/src/spl_three_to_five.f90".
2787:  OSError: [Errno 2] No such file or directory: '/home/github-runner/actions-runner/_work/SIMPLE/SIMPLE/src/plag_coeff.f90'. Skipping file "/home/github-runner/actions-runner/_work/SIMPLE/SIMPLE/src/plag_coeff.f90".
2788:  OSError: [Errno 2] No such file or directory: '/home/github-runner/actions-runner/_work/SIMPLE/SIMPLE/src/binsrc.f90'. Skipping file "/home/github-runner/actions-runner/_work/SIMPLE/SIMPLE/src/binsrc.f90".
2789:  get_useparameters: mapping for {'only': 1, 'map': {'psimax': 'psimax'}} not impl.
...

3306:  LIBNEO_BRANCH: feature/fpm-bind
3307:  ##[endgroup]
3308:  cmake --build build --config Release
3309:  [1/1] cd /home/github-runner/actions-runner/_work/SIMPLE/SIMPLE/build/_deps/libneo-src/extra/MyMPILib && /home/github-runner/actions-runner/_work/SIMPLE/SIMPLE/build/_deps/libneo-src/extra/MyMPILib/Scripts/do_versioning.sh
3310:  Versioning MyMPILib...
3311:  cd build && ctest --test-dir test --output-on-failure   -LE "slow|regression"
3312:  Internal ctest changing into directory: /home/github-runner/actions-runner/_work/SIMPLE/SIMPLE/build/test
3313:  Test project /home/github-runner/actions-runner/_work/SIMPLE/SIMPLE/build/test
3314:  Start  1: generate_chartmap_map2disc
3315:  1/47 Test  #1: generate_chartmap_map2disc ......................   Passed    8.21 sec
3316:  Start  2: generate_chartmap_ncsx_map2disc
3317:  2/47 Test  #2: generate_chartmap_ncsx_map2disc .................   Passed    8.80 sec
3318:  Start  3: generate_chartmap_ncsx_map2disc_wall
3319:  3/47 Test  #3: generate_chartmap_ncsx_map2disc_wall ............   Passed    9.82 sec
3320:  Start  4: test_chartmap_ncsx_map2disc_wall_offset
3321:  4/47 Test  #4: test_chartmap_ncsx_map2disc_wall_offset .........***Failed    0.64 sec
3322:  chartmap wall deviates from buffered VMEC boundary: max_to_buffer=6.801169e-03 m (tol 1.000000e-03) at phi=0.253866
...

3394:  40/47 Test #54: test_orbit_refcoords_rk45_plot ..................   Passed    0.89 sec
3395:  Start 55: test_orbit_chartmap_comparison
3396:  41/47 Test #55: test_orbit_chartmap_comparison ..................   Passed    6.04 sec
3397:  Start 56: test_chartmap_refcoords_config
3398:  42/47 Test #56: test_chartmap_refcoords_config ..................   Passed    0.36 sec
3399:  Start 59: test_orbit_chartmap_comparison_plot
3400:  43/47 Test #59: test_orbit_chartmap_comparison_plot .............   Passed    0.77 sec
3401:  Start 60: test_orbit_chartmap_comparison_map2disc
3402:  44/47 Test #60: test_orbit_chartmap_comparison_map2disc .........   Passed    6.20 sec
3403:  Start 61: test_orbit_chartmap_comparison_plot_map2disc
3404:  45/47 Test #61: test_orbit_chartmap_comparison_plot_map2disc ....   Passed    0.81 sec
3405:  Start 62: test_chartmap_refcoords_config_map2disc
3406:  46/47 Test #62: test_chartmap_refcoords_config_map2disc .........   Passed    0.36 sec
3407:  Start 73: test_engineering
3408:  47/47 Test #73: test_engineering ................................   Passed    1.37 sec
3409:  98% tests passed, 1 tests failed out of 47
3410:  Label Time Summary:
3411:  engineering    =   1.37 sec*proc (1 test)
3412:  integration    = 175.88 sec*proc (23 tests)
3413:  performance    =   0.53 sec*proc (1 test)
3414:  plot           =   4.52 sec*proc (7 tests)
3415:  python         =  80.49 sec*proc (15 tests)
3416:  system         =  18.80 sec*proc (3 tests)
3417:  unit           =   5.57 sec*proc (5 tests)
3418:  Total Test time (real) = 221.03 sec
3419:  The following tests FAILED:
3420:  4 - test_chartmap_ncsx_map2disc_wall_offset (Failed)  integration plot python
3421:  Errors while running CTest
3422:  make: *** [Makefile:47: test-fast] Error 8
3423:  ##[error]Process completed with exit code 2.
3424:  ##[group]Run actions/upload-artifact@v4
3425:  with:
3426:  name: test-results
3427:  path: build/Testing/
3428:  
3429:  if-no-files-found: warn
3430:  compression-level: 6
3431:  overwrite: false
3432:  include-hidden-files: false
3433:  env:
3434:  LIBNEO_BRANCH: feature/fpm-bind
3435:  ##[endgroup]
3436:  ##[warning]No files were found with the provided path: build/Testing/. No artifacts will be uploaded.
3437:  Post job cleanup.
3438:  Unexpected error attempting to determine if executable file exists '/home/ert/.npm-global/bin/git': Error: EACCES: permission denied, stat '/home/ert/.npm-global/bin/git'
3439:  Unexpected error attempting to determine if executable file exists '/home/ert/code/.venv/bin/git': Error: EACCES: permission denied, stat '/home/ert/code/.venv/bin/git'
3440:  Unexpected error attempting to determine if executable file exists '/home/ert/code/scripts/git': Error: EACCES: permission denied, stat '/home/ert/code/scripts/git'
3441:  [command]/usr/bin/git version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Review effort 3/5

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@krystophny