Skip to content

Update get tasks #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
WadeCStern merged 3 commits into from
Mar 24, 2025
Merged

Update get tasks #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
df2712e
Modified get tasks to include task type.
WadeCStern Mar 21, 2025
0ae7d66
Merge branch 'Update-get-tasks' of github.com:WadeCStern/itential.pla…
WadeCStern Mar 21, 2025
aa7e688
Fixed documentation
WadeCStern Mar 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions plugins/action/get_tasks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
# SPDX-License-Identifier: GPL-3.0-or-later

# Retrieves list of tasks from Itential Platform. Supports filtering via parameters.
# Returns: List of task objects with their status and details.
# Returns: List of task objects with their status, details, and type.
# Example:
# - name: Get tasks by status
# itential.platform.get_tasks:
Expand Down Expand Up @@ -33,6 +33,6 @@ def run(self, tmp=None, task_vars=None):

method = "GET"

params["include"] = "name,status"
params["include"] = "name,status,type"

return make_request(task_vars, method, endpoint, params=params)
2 changes: 1 addition & 1 deletion plugins/action/restart_adapters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,4 +53,4 @@ def run(self, tmp=None, task_vars=None):
response = make_request(task_vars, method, endpoint)
results.append(response)

return {"results": results} # Always return a list
return {"results": results}
6 changes: 2 additions & 4 deletions tests/unit/test_input_action_module.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,11 @@
@pytest.mark.parametrize("action_module_class, input_args, expected_endpoint, expected_method, expected_params", [
(GetJobs, {"status": "running", "name": "greg"}, "/operations-manager/jobs", "GET", {
"equals[status]": "running",
"equals[name]": "greg",
"include": "name,status"
"equals[name]": "greg"
}),
(GetTasks, {"status": "running", "name": "greg"}, "/operations-manager/tasks", "GET", {
"equals[status]": "running",
"equals[name]": "greg",
"include": "name,status"
"equals[name]": "greg"
}),
])
@patch("ansible_collections.itential.core.plugins.module_utils.http.send_request")
Expand Down