Conversation
…ports in module_utils/commonimports.py Aquiring the auth token and sending the api request are universal parts of the code so i made the initialize request and execute request functions. For most modules we just need to modify the params, the url, and the method.
…it tests. Combined modules into more generic modules that can accept arguments.
…rror handling from itential.core http module.
… Updated unit tests
plugins/modules/generic_request.py
Outdated
Contributor
There was a problem hiding this comment.
Can you add the choices field here and specify the method values as the only choices?
choices: GET, PUT, POST, DELETE
We can also make GET the default value.
tests/unit/test_generic_request.py
Outdated
Contributor
There was a problem hiding this comment.
High-five! This is a great test class, seems to cover all the basic cases.
steven-schattenberg-itential
approved these changes
Feb 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.