Closed
Conversation
Issue found during testing and updating code to support
Author
|
Reviewers: @Nick-Andreano and @privateip |
privateip
requested changes
Dec 18, 2024
Member
privateip
left a comment
privateip
left a comment
There was a problem hiding this comment.
I don't think we should have be applying conditional logic at here, that should be the responsibility of the calling function. In fact, I would asset that this library should even test for data type nor should it encoding the data using json.dumps. I think we need to remove that logic and handle this upstream in the stack
Member
|
Fixed in #9 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue found during testing and updating code to support.
removing double type casting and using data directly instead.